Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor IO errors in list-images sub-command #5330

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 9, 2024

Description

Previously, the sub-command did not interrupt the loop and returned successfully, even when it encountered IO errors while writing to standard out.

Use strings.Builder instead of bytes.Buffer: The out and err streams are always treated as strings for better readability, so it's more idiomatic to use strings.Builder for them. Replace intoLines with strings.Split, as strings.Builder doesn't implement io.Reader, which eliminates another helper function on the fly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The out and err streams are always treated as strings for better
readability, so it's more idiomatic to use strings.Builder for them.
Also, replace intoLines with strings.Split, as strings.Builder doesn't
implement io.Reader, which eliminates another helper function on the
fly.

Signed-off-by: Tom Wieczorek <[email protected]>
Previously, the sub-command did not interrupt the loop and returned
successfully, even when it encountered IO errors while writing to
standard out.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/cli labels Dec 9, 2024
@twz123 twz123 marked this pull request as ready for review December 10, 2024 19:22
@twz123 twz123 requested review from a team as code owners December 10, 2024 19:22
@twz123 twz123 requested review from ncopa and makhov December 10, 2024 19:22
@twz123 twz123 merged commit 3c2f794 into k0sproject:main Dec 11, 2024
91 checks passed
@twz123 twz123 deleted the honor-io-errs-in-list-images branch December 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants